From 7e0dbe79bfa47d396d02f69af2c1fb8fb6ace74d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Wed, 5 Dec 2018 22:59:54 +0200 Subject: [PATCH] Stop building libcxx with LIBCXX_ABI_UNSTABLE=TRUE This didn't seem to actually be necessary, not even in the initial commit adding support for building a DLL of libcxx. It might have been necessary at some earlier point while working on building a DLL. --- README.md | 3 --- build-libcxx.sh | 3 +-- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/README.md b/README.md index fbc4fd3..ef2e58a 100644 --- a/README.md +++ b/README.md @@ -71,9 +71,6 @@ normal GCC/binutils based MinGW. - The windres replacement, llvm-rc, isn't very mature and doesn't support everything that GNU windres does. -- The DLL version of libc++ doesn't have a fixed supported ABI, so in theory, - code built against an older version of the DLL is not guaranteed to work - with a newer version of the DLL. - The toolchain defaults to using the Universal CRT (which is only available out of the box since Windows 10, but can be installed on Vista or newer) and defaults to targeting Vista. These defaults can be changed in diff --git a/build-libcxx.sh b/build-libcxx.sh index 1def9e4..60dfb3a 100755 --- a/build-libcxx.sh +++ b/build-libcxx.sh @@ -167,7 +167,7 @@ build_all() { -DLIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS=OFF \ -DLLVM_NO_OLD_LIBSTDCXX=TRUE \ -DCXX_SUPPORTS_CXX11=TRUE \ - -DCMAKE_CXX_FLAGS="$LIBCXXABI_VISIBILITY_FLAGS -D_LIBCPP_HAS_THREAD_API_WIN32 -D_LIBCPP_ABI_UNSTABLE -w" \ + -DCMAKE_CXX_FLAGS="$LIBCXXABI_VISIBILITY_FLAGS -D_LIBCPP_HAS_THREAD_API_WIN32 -w" \ .. make -j$CORES cd .. @@ -208,7 +208,6 @@ build_all() { -DLIBCXX_ENABLE_EXPERIMENTAL_LIBRARY=OFF \ -DLIBCXX_ENABLE_FILESYSTEM=OFF \ -DLIBCXX_ENABLE_STATIC_ABI_LIBRARY=TRUE \ - -DLIBCXX_ABI_UNSTABLE=TRUE \ -DLIBCXX_CXX_ABI=libcxxabi \ -DLIBCXX_CXX_ABI_INCLUDE_PATHS=../../libcxxabi/include \ -DLIBCXX_CXX_ABI_LIBRARY_PATH=../../libcxxabi/build-$arch-$type/lib \